[ML] Add functional tests for reauthorizing transforms #156699

qn895 · 2023-05-04T14:31:47Z

Summary

Part of #152009. This PR adds additional functional tests for reauthorizing transforms.

Flaky test suite runner 1: ✅ Successful after 50 runs
Flaky test suite runner 2: ✅ Successful after 50 runs

Reviewer's note:

kibana-operations: This PR also renames a functional test folder start_reset_delete to a more general actions to accommodate this new test and future tests for other actions.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2023-05-04T16:55:57Z

Pinging @elastic/ml-ui (:ml)

jbudz

ftr_configs.yml

x-pack/test/functional/apps/transform/actions/reauthorizing.ts

…eauthorizing

qn895 · 2023-05-17T16:03:25Z

@elasticmachine merge upstream

pheyos

LGTM, just added a suggestion for an additional check.

x-pack/test/functional/apps/transform/actions/reauthorizing.ts

peteharverson

Latest changes LGTM

…qn895/kibana into ml-add-func-tests-reauthorizing

qn895 · 2023-05-18T15:27:38Z

@elasticmachine merge upstream

kibana-ci · 2023-05-18T16:33:20Z

💚 Build Succeeded

Buildkite Build
Commit: 8f3ffc9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	387.1KB	387.1KB	+51.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💔 Build #128752 failed 3a0e3a2
💛 Build #128660 was flaky 1dd449a
💛 Build #126682 was flaky 7c7fbe5
💛 Build #125608 was flaky 491e02d
💚 Build #125565 succeeded 25d2372

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Add tests for reauthorizing transforms

affc263

qn895 added :ml test_ui_functional test_xpack_functional Feature:Transforms ML transforms v8.8.0 labels May 4, 2023

qn895 requested review from walterra and peteharverson May 4, 2023 14:31

qn895 self-assigned this May 4, 2023

Rename folder again

0c5e9c7

qn895 force-pushed the ml-add-func-tests-reauthorizing branch from d58afa5 to 0c5e9c7 Compare May 4, 2023 15:08

qn895 mentioned this pull request May 4, 2023

[ML] Increase Test Coverage 8.8.0 #152009

Closed

7 tasks

Rename start_reset_delete to actions to be more generic

25d2372

qn895 force-pushed the ml-add-func-tests-reauthorizing branch from 2db1baf to 25d2372 Compare May 4, 2023 15:34

qn895 marked this pull request as ready for review May 4, 2023 16:55

qn895 requested review from a team as code owners May 4, 2023 16:55

jbudz approved these changes May 4, 2023

View reviewed changes

qn895 force-pushed the ml-add-func-tests-reauthorizing branch from a0b419d to 0f60d37 Compare May 4, 2023 17:59

qn895 added the release_note:skip Skip the PR/issue when compiling release notes label May 4, 2023

More robust checks on transform's state

491e02d

qn895 force-pushed the ml-add-func-tests-reauthorizing branch from 0f60d37 to 491e02d Compare May 4, 2023 18:09

peteharverson reviewed May 5, 2023

View reviewed changes

x-pack/test/functional/apps/transform/actions/reauthorizing.ts Outdated Show resolved Hide resolved

x-pack/test/functional/apps/transform/actions/reauthorizing.ts Outdated Show resolved Hide resolved

qn895 requested a review from pheyos May 8, 2023 17:57

qn895 added 2 commits May 9, 2023 13:16

Merge remote-tracking branch 'upstream/main' into ml-add-func-tests-r…

3905259

…eauthorizing

Fix comment & log msg

7c7fbe5

peteharverson added v8.9.0 and removed v8.8.0 labels May 17, 2023

Merge branch 'main' into ml-add-func-tests-reauthorizing

1dd449a

pheyos approved these changes May 17, 2023

View reviewed changes

x-pack/test/functional/apps/transform/actions/reauthorizing.ts Show resolved Hide resolved

peteharverson approved these changes May 17, 2023

View reviewed changes

qn895 added 2 commits May 17, 2023 14:54

Add expect reauthorize disabled or missing

cc8cddc

Merge branch 'ml-add-func-tests-reauthorizing' of https://github.com/…

3a0e3a2

…qn895/kibana into ml-add-func-tests-reauthorizing

Merge branch 'main' into ml-add-func-tests-reauthorizing

8f3ffc9

qn895 merged commit 3766cd6 into elastic:main May 18, 2023

kibanamachine added the backport:skip This commit does not require backporting label May 18, 2023

delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023

[ML] Add functional tests for reauthorizing transforms (elastic#156699)

fded14a

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Add functional tests for reauthorizing transforms #156699

[ML] Add functional tests for reauthorizing transforms #156699

qn895 commented May 4, 2023 •

edited

Loading

elasticmachine commented May 4, 2023

jbudz left a comment

qn895 commented May 17, 2023

pheyos left a comment

peteharverson left a comment

qn895 commented May 18, 2023

kibana-ci commented May 18, 2023

ESLint disabled line counts

Total ESLint disabled count

[ML] Add functional tests for reauthorizing transforms #156699

[ML] Add functional tests for reauthorizing transforms #156699

Conversation

qn895 commented May 4, 2023 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

elasticmachine commented May 4, 2023

jbudz left a comment

Choose a reason for hiding this comment

qn895 commented May 17, 2023

pheyos left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

qn895 commented May 18, 2023

kibana-ci commented May 18, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

qn895 commented May 4, 2023 •

edited

Loading